Skip to content

Improvements to "Reset the Arduino bootloader on the Nano ESP32" [HC-1612] #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

Improvements to "Reset the Arduino bootloader on the Nano ESP32" [HC-1612] #445

merged 4 commits into from
Nov 6, 2024
+54 −7

Conversation

seaxwi
Copy link
Collaborator

@seaxwi seaxwi commented Nov 4, 2024

Document bootloader mode option and clarify some steps based on article feedback

@seaxwi seaxwi requested a review from Renat0Ribeir0 November 4, 2024 11:30
Renat0Ribeir0
Renat0Ribeir0 suggested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Renat0Ribeir0 Renat0Ribeir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some minor suggestions. Also, since it is mentioned that this process works in Arduino IDE and Cloud Editor ("3. Select Arduino Nano ESP32 in Arduino IDE or the Cloud Editor."), the intro should be updated.

@seaxwi
Copy link
Collaborator Author

seaxwi commented Nov 6, 2024

since it is mentioned that this process works in Arduino IDE and Cloud Editor ("3. Select Arduino Nano ESP32 in Arduino IDE or the Cloud Editor."), the intro should be updated.

@Renat0Ribeir0 Good point! Programmer selection is not available in the Cloud Editor, but that's only needed for the option 2. I have made some adjustmens in e568360

@seaxwi seaxwi requested a review from Renat0Ribeir0 November 6, 2024 10:35
@seaxwi seaxwi merged commit c764f7c into main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Renat0Ribeir0 Renat0Ribeir0 Renat0Ribeir0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaxwi @Renat0Ribeir0